At work, there is a bit of Legacy around.
The following example of several Enum classes we have, is what is currently frustrating me (and I try actively to change them).
Let's enumerate (oh, look, I made a joke) the issues:
Replacing magic numbers with constants and enums is, of course, one of the Good Thingstm.
But in this example, they seem to have totally missed the point.
Not only have they replaced magic numbers with "magic enums", it's an eyesore to use the underscore in the Enum instances.
When you have to take refuge in the use of underscores to make things work, it is a sure sign that you are doing something seriously wrong.
No comments:
Post a Comment